This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Update bidder API endpoint to provide_allowance rather than prepay #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ckartik
commented
Mar 10, 2024
ckartik
commented
- This ensures consistent naming around the concept of allowance, avoiding User confusion.
| @@ -33,7 +33,7 @@ service Bidder { | |||
| // | |||
| // PrepayAllowance is called by the bidder node to add prepaid allowance in the bidder registry. | |||
| rpc PrepayAllowance(PrepayRequest) returns (PrepayResponse) { | |||
| option (google.api.http) = {post: "/v1/bidder/prepay/{amount}"}; | |||
| option (google.api.http) = {post: "/v1/bidder/provide_allowance/{amount}"}; | |||
There was a problem hiding this comment.
I dont really like this name. Plus the RPC function is still called PrepayAllowance. Not sure where this 'provide' came from.
There was a problem hiding this comment.
prepay_allowance seems like a reasonable name
There was a problem hiding this comment.
we want to move away from the term prepay.
There was a problem hiding this comment.
This API actually moves funds from the account. So I think provide allowance would actually be misguiding. Prepay seems to be better.
|
@ckartik Lets go with prepay allowance and please take this to completion |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.