feat: e2e privacy integration #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikelle
reviewed
Apr 11, 2024
pkg/events/events.go
Outdated
|
|
||
| logChan := make(chan types.Log) | ||
|
|
||
| sub, err := l.evmClient.SubscribeFilterLogs(ctx, q, logChan) |
There was a problem hiding this comment.
The EvmClient needs to be initialized with a WebSocket endpoint; otherwise, it will return a 'subscription is not supported' error. I faced this issue before
There was a problem hiding this comment.
I have changed it to not use the subscription function. I have nothing against the subscription implementation, but I think it is better to have this package work with the default rpc client. Also I dont want to add setup in infra for this as its not critical.
added 19 commits
April 12, 2024 04:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.