Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: fee param cleanup #21

Merged
merged 2 commits into from
Feb 7, 2024
Merged

config: fee param cleanup #21

merged 2 commits into from
Feb 7, 2024

Conversation

shaspitz
Copy link

@shaspitz shaspitz commented Feb 6, 2024

  • Removes red herring values in genesis.json that do not affect gas params.
  • Explicitly sets miner.gasprice to default value value. miner.gasprice represents minimum priority fee from this line.
  • Explicitly sets gpo.maxprice to default value, representing max priority fee that is suggested by gasPrice oracle.

@shaspitz shaspitz marked this pull request as ready for review February 6, 2024 02:00
@shaspitz
Copy link
Author

shaspitz commented Feb 6, 2024

I've confirmed rpc suggestions are as expected. Suggested priority fee is 1 gwei, 0-demand base fee is 7 wei:

shawn@Shawns-MacBook-Pro ~ % curl -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0", "method":"eth_maxPriorityFeePerGas", "params":[], "id":1}' http://localhost:8545
{"jsonrpc":"2.0","id":1,"result":"0x3b9aca00"}
shawn@Shawns-MacBook-Pro ~ % curl -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"eth_feeHistory","params":[10, "latest", []],"id":1}' http://localhost:8545
{"jsonrpc":"2.0","id":1,"result":{"oldestBlock":"0x1df","baseFeePerGas":["0x7","0x7","0x7","0x7","0x7","0x7","0x7","0x7","0x7","0x7","0x7"],"gasUsedRatio":[0,0,0,0,0,0,0,0,0,0]}}
shawn@Shawns-MacBook-Pro ~ % curl -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0", "method":"eth_gasPrice", "params":[], "id":1}' http://localhost:8545
{"jsonrpc":"2.0","id":1,"result":"0x3b9aca07"}
shawn@Shawns-MacBook-Pro ~ %

@shaspitz
Copy link
Author

shaspitz commented Feb 7, 2024

Signers do not finalize low tip txes as expected when this PR is rebased onto ethereum#28933

@shaspitz shaspitz merged commit 552a9cf into master Feb 7, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants