New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only allow Oracle to post data + Nit cleanup #71

Merged

ckartik merged 1 commit into main from ckartik/owner-oracle

Jan 2, 2024

Contributor

ckartik commented Jan 1, 2024

Restricts call to process commitment to only by via oracle.
Sets subsequent internal call from oracle to private function to disallow external calls.
Makes cleanup of commented out code and updates test for owner only calls.
Checks to ensure block number also matches commitment internals


          Oracle contract cleanup and set only owner.

22ae3f7

ckartik requested a review from kant777

January 1, 2024 19:39

kant777 approved these changes

View reviewed changes

Contributor

kant777 left a comment

I am assuming this will change the abi and contract address if so please fix them in other repos and test to make sure it works.

kant777 requested changes

View reviewed changes

test/OracleTest.sol Show resolved Hide resolved

ckartik mentioned this pull request

Updates oracle to match new Contracts primev/mev-commit-oracle#16

Merged

kant777 approved these changes

View reviewed changes

ckartik merged commit 8555edb into main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet