Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add align-self: flex-start to group heading directly #2972

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented Jul 26, 2024

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Applies flex-start directly to the group heading in ActionList. This ensures that anything inside of .ActionList-sectionDivider that isn't the group heading won't receive the align-items style.

Integration

List the issues that this change affects.

Closes # (type the GitHub issue number after #)

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Jul 26, 2024

🦋 Changeset detected

Latest commit: cb593b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TylerJDev TylerJDev changed the title Add align-self: flex-start to the "heading" title directly Add align-self: flex-start to group heading directly Jul 26, 2024
@TylerJDev TylerJDev marked this pull request as ready for review July 26, 2024 16:14
@TylerJDev TylerJDev requested review from a team as code owners July 26, 2024 16:14
@TylerJDev TylerJDev requested review from lukasoppermann and camertron and removed request for a team July 26, 2024 16:14
@camertron camertron merged commit 9b675a7 into main Jul 26, 2024
38 checks passed
@camertron camertron deleted the fix-align-bug branch July 26, 2024 16:39
@primer primer bot mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants