Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include role="option" as a valid selector for focus-group #2924

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

kendallgassner
Copy link
Contributor

What

Include role="option" as a valid selector for focus-group

Screenshots

Integration

List the issues that this change affects.

Closes # (type the GitHub issue number after #)

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

### What 

Include `role="option"` as a valid selector for focus-group
@kendallgassner kendallgassner requested a review from a team as a code owner June 27, 2024 18:53
@kendallgassner kendallgassner requested a review from joshblack June 27, 2024 18:53
Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: 23190f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kendallgassner kendallgassner merged commit 235544d into main Jun 27, 2024
37 checks passed
@kendallgassner kendallgassner deleted the kendallgassner-patch-1 branch June 27, 2024 19:24
@primer primer bot mentioned this pull request Jun 26, 2024
@kendallgassner kendallgassner changed the title Update focus_group.ts Include role="option" as a valid selector for focus-group Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants