Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving ProgressBar component css #1583

Merged
merged 7 commits into from
Nov 9, 2022
Merged

Moving ProgressBar component css #1583

merged 7 commits into from
Nov 9, 2022

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Nov 7, 2022

Description

tracking https://github.com/github/primer/issues/1342

This pull request has the goal to move CSS for the Progress Bar component from primer/css to here.

  1. moves the Primer::ProgressBarComponent to Primer::Beta::ProgressBar.
  2. Deprecates old Primer::ProgressBarComponent name
  3. Adds new progress_bar.pcss file.

Integration

Does this change require any updates to code in production?

Yes, this line should be removed on dotcom:

- @import '@primer/css/progress/progress.scss';

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2022

🦋 Changeset detected

Latest commit: 4931cda

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added css Pull requests that update CSS code ruby Pull requests that update Ruby code labels Nov 7, 2022
@jonrohan jonrohan changed the title Progress bar Moving ProgressBar component css Nov 7, 2022
@jonrohan jonrohan temporarily deployed to review-pr-1583 November 7, 2022 23:19 Inactive
@jonrohan jonrohan temporarily deployed to github-pages November 7, 2022 23:23 Inactive
@jonrohan jonrohan temporarily deployed to review-pr-1583 November 8, 2022 00:04 Inactive
@jonrohan jonrohan temporarily deployed to github-pages November 8, 2022 00:09 Inactive
@jonrohan jonrohan temporarily deployed to review-pr-1583 November 8, 2022 03:13 Inactive
@jonrohan jonrohan temporarily deployed to github-pages November 8, 2022 03:17 Inactive
@jonrohan jonrohan marked this pull request as ready for review November 8, 2022 03:37
@jonrohan jonrohan requested a review from a team as a code owner November 8, 2022 03:37
@jonrohan jonrohan requested review from a team, langermank and camertron November 8, 2022 03:37
app/components/primer/beta/progress_bar.rb Outdated Show resolved Hide resolved
@jonrohan jonrohan temporarily deployed to github-pages November 8, 2022 17:29 Inactive
@jonrohan jonrohan merged commit a06f52c into main Nov 9, 2022
@jonrohan jonrohan deleted the progress_bar branch November 9, 2022 01:12
@primer-css primer-css mentioned this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Pull requests that update CSS code ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants