Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate static files / rake static:dump is failing on main #3263

Closed
myabc opened this issue Jan 13, 2025 · 0 comments · Fixed by #3265
Closed

Generate static files / rake static:dump is failing on main #3263

myabc opened this issue Jan 13, 2025 · 0 comments · Fixed by #3265
Assignees
Labels

Comments

@myabc
Copy link
Contributor

myabc commented Jan 13, 2025

Problem / to reproduce

The following Rake tasks currently fail on main when run in succession:

bundle exec rake utilities:build
bundle exec rake static:dump

As such, the Generate static files workflow is failing - example here: https://github.com/primer/view_components/actions/runs/12715218479/job/35446972701

Details

bundle exec rake utilities:build leaves lib/primer/classify/utilities.yml dirty by changing how keys are generated:

diff --git a/lib/primer/classify/utilities.yml b/lib/primer/classify/utilities.yml
index 265e163d3..96d376e6e 100644
--- a/lib/primer/classify/utilities.yml
+++ b/lib/primer/classify/utilities.yml
@@ -1,5 +1,5 @@
 ---
-:animation:
+:anim:
   :fade_in:
   - anim-fade-in
   :fade_out:
@@ -23,126 +23,124 @@
   :rotate:
   - anim-rotate
 :color:
-  :default:
+  :fg_default:
   - color-fg-default
-  :muted:
+  :fg_muted:
   - color-fg-muted
-  :subtle:
+  :fg_subtle:
   - color-fg-subtle
-  :accent:
+  :fg_accent:
   - color-fg-accent

Workaround / fix

The culprit appears to be #3177 - merged back in November. Reverting 308a56b resolves this issue. #3265 should fix the issue.

myabc added a commit to opf/primer_view_components that referenced this issue Jan 13, 2025
This should fix classname keys when generating `lib/primer/classify/utilities.yml` with `bundle exec rake utilities:build`.

Fixes primer#3263
Relates to primer#3177
@myabc myabc changed the title Generate static files / rake static:dump is failing on main. Generate static files / rake static:dump is failing on main Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants