Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update box shadow to match Primer CSS Next #732

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Conversation

colebemis
Copy link
Contributor

@colebemis colebemis commented Mar 27, 2020

This PR updates shadow.small, shadow.medium, shadow.large, and shadow['extra-large'] in the theme to match $box-shadow-small, $box-shadow-medium, $box-shadow-large, and $box-shadow-extra-large in Primer CSS Next: primer/css#1040

Merge checklist

  • Added or updated TypeScript definitions (index.d.ts) if necessary
  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@vercel
Copy link

vercel bot commented Mar 27, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-components/4ga6qtwe2
✅ Preview: https://primer-components-git-update-box-shadow.primer.now.sh

@colebemis colebemis requested a review from emplums March 27, 2020 20:38
@colebemis colebemis marked this pull request as ready for review March 27, 2020 20:39
@vercel vercel bot temporarily deployed to Preview March 30, 2020 20:22 Inactive
@emplums emplums changed the base branch from master to major April 1, 2020 21:43
Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@emplums emplums merged commit b8b43cf into major Apr 1, 2020
@emplums emplums deleted the update-box-shadow branch April 1, 2020 21:43
@emplums emplums mentioned this pull request Apr 1, 2020
8 tasks
acknosyn added a commit to acknosyn/components that referenced this pull request Apr 14, 2020
…dow"

Update box shadow to match Primer CSS Next

- (Edit) add commit b8b43c, minus conflicts from recent changes to files
@BinaryMuse BinaryMuse mentioned this pull request Apr 14, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants