Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove axe e2e tests that are duplicated in axe.test.ts #5653

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kendallgassner
Copy link
Contributor

@kendallgassner kendallgassner commented Feb 3, 2025

Follow up of: #5648

In #5592 we created a script that would run axe on every singles Storybook story (unless added to SKIPPED_TESTS. Doing so allows us to remove several @aat tests in our e2e testing suite that are duplicated by the axe tests. This PR removes some of those tests. A follow up PR will remove more.

This PR does/should not remove any @aat tests that runs axe when a state is changed. For example if an @aat test opens a dialog in the storybook story the axe.test.ts script would not be a duplicate of that test.

color-contrast is off by default

Closes #

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Feb 3, 2025

⚠️ No Changeset found

Latest commit: 74cbbcf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kendallgassner kendallgassner added the skip changeset This change does not need a changelog label Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.38 KB (0%)
packages/react/dist/browser.umd.js 105.83 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-5653 February 3, 2025 23:10 Abandoned
@kendallgassner kendallgassner marked this pull request as ready for review February 4, 2025 00:10
@kendallgassner kendallgassner requested a review from a team as a code owner February 4, 2025 00:10
@francinelucca francinelucca changed the title Remove axe e2e tests that are diplicated in axe.test.ts Remove axe e2e tests that are duplicated in axe.test.ts Feb 4, 2025
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants