Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move multiple component's feature flags from primer_react_css_modules_staff to primer_react_css_modules_ga #5591

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

jonrohan
Copy link
Member

Part of https://github.com/github/primer/issues/4641

This moves multiple components from staff to ga

Changelog

New

Changed

  • Move Popover CSS modules feature flag from staff to ga
  • Move Textarea CSS modules feature flag from staff to ga
  • Move UnstyledTextInput CSS modules feature flag from staff to ga
  • Move SelectPanel2 CSS modules feature flag from staff to ga
  • Move Breadcrumbs CSS modules feature flag from staff to ga
  • Move ProgressBar CSS modules feature flag from staff to ga
  • Move Dialog CSS modules feature flag from staff to ga
  • Move DialogV1 CSS modules feature flag from staff to ga
  • Move TreeView CSS modules feature flag from staff to ga
  • Move CheckboxOrRadioGroup CSS modules feature flag from staff to ga

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan jonrohan requested a review from a team as a code owner January 23, 2025 18:03
@jonrohan jonrohan requested a review from camertron January 23, 2025 18:03
Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: ff40a93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan requested a review from TylerJDev January 23, 2025 18:03
@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 23, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.54 KB (+0.01% 🔺)
packages/react/dist/browser.umd.js 104.86 KB (-0.05% 🔽)

@jonrohan jonrohan added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 12f1af7 Jan 23, 2025
46 checks passed
@jonrohan jonrohan deleted the primer_css_modules_move_to_ga branch January 23, 2025 19:14
@primer primer bot mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants