Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ActionList.LinkItem duplicate classes #5517

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

francinelucca
Copy link
Member

Part of https://github.com/github/primer/issues/4570

Fixes an issue where className was being duplicated in LinkItem on both the wrapper li (correct) and the inner a tag (incorrect).

Changelog

Removed

  • Removes className from menuItemProps in ActionList.Item

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@francinelucca francinelucca requested a review from a team as a code owner January 9, 2025 17:02
Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: b7bbea6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@francinelucca francinelucca changed the title remove className from menuItemProps fix: ActionList.LinkItem duplicate classes Jan 9, 2025
@github-actions github-actions bot added the staff Author is a staff member label Jan 9, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Jan 9, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.88 KB (-0.05% 🔽)
packages/react/dist/browser.umd.js 104.19 KB (-0.04% 🔽)

@francinelucca francinelucca added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit c828e03 Jan 9, 2025
42 checks passed
@francinelucca francinelucca deleted the fix/action-list-duplicate-classes branch January 9, 2025 17:22
@primer primer bot mentioned this pull request Jan 9, 2025
francinelucca added a commit that referenced this pull request Jan 9, 2025
* remove className from menuItemProps

* Create little-shrimps-hug.md
@francinelucca francinelucca mentioned this pull request Jan 9, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants