Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(SideNav): Add VRT tests #5405

Merged
merged 3 commits into from
Dec 11, 2024
Merged

chore(SideNav): Add VRT tests #5405

merged 3 commits into from
Dec 11, 2024

Conversation

JelloBagel
Copy link
Contributor

@JelloBagel JelloBagel commented Dec 10, 2024

Related to https://github.com/github/primer/issues/4132

Add VRT tests for SideNav using examples from https://primer.style/deprecated-components/side-nav/react/latest

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 1f9ca0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JelloBagel JelloBagel added skip changeset This change does not need a changelog update snapshots labels Dec 10, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5405 December 10, 2024 19:22 Inactive
Copy link
Contributor

github-actions bot commented Dec 10, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.51 KB (0%)
packages/react/dist/browser.umd.js 102.98 KB (0%)

@JelloBagel JelloBagel added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit cf62ddf Dec 11, 2024
43 checks passed
@JelloBagel JelloBagel deleted the jellobagel-sidenav-vrt branch December 11, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants