Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(UnderlinePanels): add dev stories and update e2e tests #5348

Merged
merged 4 commits into from
Dec 4, 2024
Merged

chore(UnderlinePanels): add dev stories and update e2e tests #5348

merged 4 commits into from
Dec 4, 2024

Conversation

randall-krauskopf
Copy link
Contributor

Related To: https://github.com/github/primer/issues/4308

  • Adds dev stories
  • Updates e2e tests to new format

@randall-krauskopf randall-krauskopf added the skip changeset This change does not need a changelog label Dec 3, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b4791b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-5348 December 3, 2024 20:11 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.73 KB (0%)
packages/react/dist/browser.umd.js 104.06 KB (0%)

@primer primer bot temporarily deployed to github-pages December 3, 2024 20:20 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5348 December 3, 2024 20:20 Inactive
@randall-krauskopf randall-krauskopf marked this pull request as ready for review December 3, 2024 22:33
@randall-krauskopf randall-krauskopf requested review from a team as code owners December 3, 2024 22:33
@randall-krauskopf randall-krauskopf added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit e2a85e0 Dec 4, 2024
43 checks passed
@randall-krauskopf randall-krauskopf deleted the underline-panels-vrt branch December 4, 2024 00:06
francinelucca added a commit that referenced this pull request Dec 5, 2024
@francinelucca
Revert "chore(UnderlinePanels): add dev stories and update e2e tests (#…
19758dc 
…5348)"

This reverts commit e2a85e0.
francinelucca added a commit that referenced this pull request Dec 5, 2024
@francinelucca
Revert "chore(UnderlinePanels): add dev stories and update e2e tests (#…
593952c 
…5348)"

This reverts commit e2a85e0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@maximedegreve maximedegreve Awaiting requested review from maximedegreve maximedegreve is a code owner automatically assigned from primer/design-reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randall-krauskopf @joshblack