-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Token): Migrate to CSS modules behind feature flag Pt 2 #5271
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 635be65 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
Integration tests are failing due to the regression that should be fixed soon. |
display: block; | ||
} | ||
|
||
/* TODO: Remove this once the avatar component is converted to CSS modules */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avatar is converted #5221
padding-left: var(--base-size-4) !important; | ||
} | ||
|
||
.AvatarContainer[data-size='small'] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.AvatarContainer[data-size='small'] { | |
.AvatarContainer:where([data-size='small']) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jonrohan, I'll get these changes in. Quick question though, why is :where
preferred over the bare attribute selector?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where will reduce the specificity on the attribute selector and make it easier to override the styles in dotcom. We try and add it whenever the attribute lands on the same dom node where we add the passed in className
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/350928 |
🔴 golden-jobs completed with status |
Related To: https://github.com/github/primer/issues/4367
This PR is part 2 of breaking apart a larger PR into grokkable parts.
Apologies for the larger PR but there was an odd interplay with the specificity across the various components that made it hard to break this PR into smaller chunks