chore(deps): update react, react-dom, testing-library #4646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
size-limit report 📦
|
siddharthkp
reviewed
Jun 6, 2024
| @@ -118,7 +118,7 @@ const InlineAutocomplete = ({ | |||
| const inputProps = useFormControlForwardedProps(externalInputProps) | |||
|
|
|||
| const inputRef = useRef<HTMLInputElement & HTMLTextAreaElement>(null) | |||
| useRefObjectAsForwardedRef(children.ref ?? noop, inputRef) | |||
| useRefObjectAsForwardedRef(children.ref && typeof children.ref !== 'string' ? children.ref : noop, inputRef) | |||
There was a problem hiding this comment.
The string comparison seems like a bonus here, did this show up as validation error with the new version?
There was a problem hiding this comment.
@siddharthkp yeah! Just showed up as a TS error
siddharthkp
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
react,react-dom,@testing-libraryand corresponding@types/*dependencies to the latest version. This will only update our internal dependencies, not the dependencies that we expect from downstream users.Changelog
New
Changed
actfromreact-dom/test-utilstoreactRemoved
Rollout strategy