Tooltip V2: Update the threshold value to match with the offset #4446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4cfde9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
broccolinisoup
changed the title
broccolinisoup
changed the title
broccolinisoup
changed the title
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
broccolinisoup
changed the title
10 tasks
broccolinisoup
commented
Mar 28, 2024
| @@ -62,7 +62,7 @@ const StyledTooltip = styled.span` | |||
| display: block; | |||
| right: 0; | |||
| left: 0; | |||
| height: 8px; | |||
| height: var(--overlay-offset, 0.25rem); | |||
There was a problem hiding this comment.
@langermank should this be 4px or 0.25rem?
There was a problem hiding this comment.
What you have is perfect!
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
keithamus
approved these changes
Mar 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in the communities (https://github.com/orgs/community/discussions/113546) and also internally that the elements that have tooltips on are not fully clickable. The reported issue is on PVC tooltip but React doesn't have the right value either. We think this is happening because the threshold (12px) is higher than the offset value (4px) and tooltip ends up blocking out the bottom part of its trigger.
Corresponding PVC PR: primer/view_components#2733
Changelog
New
Changed
Updated the height of the after pseudo element (Between tooltip and its trigger) to match with the offset value (default) so that tooltip don't overlap with its trigger.
Removed
Rollout strategy
Testing & Reviewing
Merge checklist