ActionList semantics re-introduce

[broccolinisoup]

Context

ActionList semantic github/accessibility-audits#2939 PRs were reverted because they were causing tests to fail at github/github. This PR re-introduces them (except 1 PR that is not stricken through) with some test and usage fixes required in the upstream dotcom.

• Update PRC ActionList implementation to have similar semantics to PVC. #2878
• NavList: Fix group dividers #3328
• Fix create-slots utils path in ActionList file #3223
• Add back check for GroupContext in ActionList.Selection to fix issues introduced to github/github #3267
• fix(ActionList): update to read from group context if selectionVarian… #3269
• Refactor(ActionList): ActionList.Item should render content as a button if parent is not interactive. #3284

What is changed

1) Update PRC ActionList implementation to have similar semantics to PVC.

Deprecating ActionList.Group is not a final decision - we are exploring remediating the semantics while keeping the API the same

• Deprecated ActionList.Group.
• Adds ActionList.Heading to be used for labelling children in an ActionList.

2) Render ActionList.Item as button

The ActionList.Item content should render an interactive button. Exceptions are when the outermost element of the ActionList.Item is an interactive element. Examples of this include NavList (where ActionList.Items can be render as a button) and in ActionMenu, where the top-level element is made interactive with the menuitem role.

github/github fixes

Integration PR: https://github.com/github/github/pull/278891

1. There are ActionList.Item usages that has Link component as a child. GH search (Github stuff only link) and with the new change it generates an inaccessible markup like:

<button> 👉🏻 `ActionList.Item` now is rendered as button 
  <a href="..."> link text </a>
</button>

I refactored these usages to use ActionList.LinkItem commit reference (GitHub stuff only link)

2. There are ActionList.Item usages that has role=button attribute and now ActionList.Item also returns as button, first the role attribute becomes unnecessary and it fails some tests that looks for buttons getByRole('button') because it returns multiple.GH search (Github stuff only link)

I removed the role="button" attribute from these usages.

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

• Added/updated tests
• Added/updated documentation
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 34c738b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	127.87 KB (+25.6% 🔺)
dist/browser.umd.js	128.11 KB (+25.17% 🔺)

[broccolinisoup]

We are re-introducing the remediations iteratively and without any changes in the API. Please see my comment on the issue for more details and the active PRs. https://github.com/github/accessibility-audits/issues/2939#issuecomment-1635386101 Therefore, I am closing this PR.