-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🛠️ [Bug Fix] Setting DialogV2
backdrop to the proper variable
#3411
Conversation
🦋 Changeset detectedLatest commit: 78253d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Uh oh! @dusave, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@dusave was adding this to the merge queue but saw that you disabled auto merge last week (sorry about that!) Let me know if this is good to go or if you wanted to make any additional changes! |
@joshblack ah, thanks for the heads up! I was meaning to follow up on the merge process. This bad boy is ready to go! |
This fixes a bug where the DialogV2 backdrop is not set to the proper CSS variable
Screenshots
Before:
background-color: rgba(0, 0, 0, 0.4);
After:
background-color: rgba(31,35,40,0.5);
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.