Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ [Bug Fix] Setting DialogV2 backdrop to the proper variable #3411

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

dusave
Copy link
Contributor

@dusave dusave commented Jun 13, 2023

This fixes a bug where the DialogV2 backdrop is not set to the proper CSS variable

Screenshots

Before:
image
background-color: rgba(0, 0, 0, 0.4);

After:
image
background-color: rgba(31,35,40,0.5);

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@dusave dusave requested review from a team and colebemis June 13, 2023 20:09
@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023

🦋 Changeset detected

Latest commit: 78253d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Uh oh! @dusave, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 101.87 KB (0%)
dist/browser.umd.js 102.37 KB (+0.01% 🔺)

@dusave dusave temporarily deployed to github-pages June 13, 2023 20:15 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3411 June 13, 2023 20:15 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@joshblack
Copy link
Member

@dusave was adding this to the merge queue but saw that you disabled auto merge last week (sorry about that!) Let me know if this is good to go or if you wanted to make any additional changes!

@dusave
Copy link
Contributor Author

dusave commented Jun 20, 2023

@joshblack ah, thanks for the heads up! I was meaning to follow up on the merge process.

This bad boy is ready to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants