Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ActionList): import merge from sx #3271

Merged
merged 2 commits into from
May 10, 2023
Merged

Conversation

joshblack
Copy link
Member

Currently, ActionList imports the merge utility from lodash. This causes a downstream bundle increase since lodash is being brought in. This PR updates the usage to bring in merge from the sx module to avoid bringing in merge from lodash

@joshblack joshblack requested review from a team and colebemis May 10, 2023 17:05
@changeset-bot
Copy link

changeset-bot bot commented May 10, 2023

⚠️ No Changeset found

Latest commit: 30becd2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label May 10, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 96.35 KB (-20.81% 🔽)
dist/browser.umd.js 96.84 KB (-20.57% 🔽)

@joshblack joshblack requested a review from broccolinisoup May 10, 2023 18:11
@joshblack joshblack added this pull request to the merge queue May 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2023
@joshblack joshblack added this pull request to the merge queue May 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2023
@joshblack joshblack added this pull request to the merge queue May 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2023
@joshblack joshblack added this pull request to the merge queue May 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2023
@joshblack joshblack added this pull request to the merge queue May 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2023
@joshblack joshblack added this pull request to the merge queue May 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2023
@joshblack joshblack added this pull request to the merge queue May 10, 2023
Merged via the queue into main with commit 102ea81 May 10, 2023
@joshblack joshblack deleted the fix/add-lodash-merge branch May 10, 2023 21:29
@joshblack joshblack mentioned this pull request May 11, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants