Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add release schedule workflow #3268

Merged
merged 6 commits into from
May 16, 2023
Merged

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented May 9, 2023

Add in a workflow that will create a recurring issue for tracking releases. The template for this issue is roughly the following and can be updated:

---
title: Release Tracking
---

<!-- primer-release-schedule:2022-05-08 -->

_This is a scheduled issue for tracking the release between May 8th and May 12th_

| Last week | Value |
| :-------- | :---- |
| Issue     | [Release Tracking](https://github.com/primer/react/issues/:number) |
| Conductor | @previous-conductor |

## Timeline

<!-- Provide updates for release activities, like cutting releases and different integration points -->

- May 8th
- May 9th
- May 10th
- May 11th
- May 12th

## Checklist

- [ ] Prerelease available on npm
- [ ] Integration checks passed
- [ ] Release available on npm
- [ ] Integration Pull Requests have been merged

## Notes

<!-- Provide any notes for this release that may be helpful for a future conductor or for consumers -->

Currently, the job is set to use workflow_dispatch while testing. In the future, this job should run on a cron schedule every Monday at the beginning of the week.

Would love any feedback on this approach to see what you all think! The intent here is to keep track of our release process and maintain notes week-to-week.

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2023

⚠️ No Changeset found

Latest commit: 9ebea46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 96.65 KB (0%)
dist/browser.umd.js 97.12 KB (0%)

@joshblack joshblack temporarily deployed to github-pages May 9, 2023 17:36 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3268 May 9, 2023 17:37 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3268 May 9, 2023 17:44 Inactive
@joshblack joshblack marked this pull request as ready for review May 9, 2023 17:45
@joshblack joshblack requested review from a team and josepmartins May 9, 2023 17:45
@github-actions github-actions bot temporarily deployed to storybook-preview-3268 May 9, 2023 17:48 Inactive
@joshblack joshblack temporarily deployed to github-pages May 9, 2023 17:51 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3268 May 9, 2023 17:52 Inactive
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that you added the last week's issue and the conductor! Super helpful.

Do you think it would be helpful to add another table with the release tracking PR and the integration tests PR? It wouldn't be saving a lot of time but might help maybe to see them all in one place? If it is not too much of a hassle.

I like the timeline section! Once we have some more issues, we might start seeing a pattern when we release things or common problems etc.

Regarding the checklist item "Prerelease available on npm", do we need to associate it with a specific RC? Because it might be changing everyday depending on if there are more PRs merged to main. We could maybe ask from release conductor to add the RC version when they marked this checkbox maybe? Not sure if that would be helpful for anything though.

I really love this overall and will be a huge help for the handover notes! I don't have anything else to add at this point. I think we can start using if everyone feels keen and see what works and what not?

Thanks heaps for pushing this PR 💖

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! I think this will be super helpful

@joshblack
Copy link
Member Author

@broccolinisoup thanks for the review!

Do you think it would be helpful to add another table with the release tracking PR and the integration tests PR?

Great idea! Added some quick links for both that match what we have over in raycast 👀

Regarding the checklist item "Prerelease available on npm", do we need to associate it with a specific RC? Because it might be changing everyday depending on if there are more PRs merged to main.

Great points with this, I ended up updating that checklist section with what I used over in: #3275 Let me know what you think of the changes, the prerelease step ended up being removed and now it has checks for integration tests, stable release, and merging in the integration tests

@broccolinisoup
Copy link
Member

@joshblack I love the updates! Thanks so much for this 🙏🏻

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joshblack joshblack added this pull request to the merge queue May 16, 2023
Merged via the queue into main with commit 1869cf7 May 16, 2023
@joshblack joshblack deleted the chore/add-release-schedule branch May 16, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants