Render Emotion CSS statically #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
|
Sorry, lemme fix the merge conflicts here. |
shawnbot
force-pushed
the
emotion-static
branch
from
370eff7 to
4cd4abb
Compare
emplums
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the styled-components static CSS rendering in #253, so I thought it might be good to instead render the Emotion styles and get rid of the more jarring parts of our Flash of Unstyled Content.
After installing
emotion-server, I upgraded a couple of our other emotion packages to the same version (9.2.8) from9.2.6just to be sure that we don't hit any cross-package compatibility issues. (Note that[email protected]wasn't available, so I left it at9.2.6.)