Moving mouseup handler

primer · May 22, 2023 · dce1126 · dce1126
1 parent d932466
commit dce1126
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/src/TreeView/TreeView.tsx b/src/TreeView/TreeView.tsx
@@ -262,20 +262,19 @@ const Root: React.FC<TreeViewProps> = ({
     setAriaLiveMessage(message)
   }, [])
 
-  const mouseDownHandler = useCallback(() => {
+  const onMouseDown = useCallback(() => {
     mouseDownRef.current = true
   }, [])
 
-  const mouseUpHandler = useCallback(() => {
-    mouseDownRef.current = false
-  }, [])
-
   useEffect(() => {
-    document.addEventListener('mouseup', mouseUpHandler)
+    function onMouseUp() {
+      mouseDownRef.current = false
+    }
+    document.addEventListener('mouseup', onMouseUp)
     return () => {
-      document.removeEventListener('mouseup', mouseUpHandler)
+      document.removeEventListener('mouseup', onMouseUp)
     }
-  })
+  }, [])
 
   useRovingTabIndex({containerRef, mouseDownRef})
   useTypeahead({
@@ -310,7 +309,7 @@ const Root: React.FC<TreeViewProps> = ({
           aria-label={ariaLabel}
           aria-labelledby={ariaLabelledby}
           data-omit-spacer={flat}
-          onMouseDown={mouseDownHandler}
+          onMouseDown={onMouseDown}
         >
           {children}
         </UlBox>