Limit jest.spy to console.warn specific tests and change changeset de…

…scription
primer · Jan 24, 2025 · b3b2235 · b3b2235
1 parent 55951e0
commit b3b2235
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 22 deletions.
diff --git a/.changeset/orange-roses-give.md b/.changeset/orange-roses-give.md
@@ -2,4 +2,4 @@
 "@primer/react": minor
 ---
 
-Changed ProgressBar.Item to require an aria-label.
+In dev mode, warn users to add an aria-label to ProgressBar.Item if the ProgressBar.Item is not aria-hidden.
diff --git a/packages/react/src/__tests__/ProgressBar.test.tsx b/packages/react/src/__tests__/ProgressBar.test.tsx
@@ -6,16 +6,6 @@ import axe from 'axe-core'
 import {FeatureFlags} from '../FeatureFlags'
 
 describe('ProgressBar', () => {
-  const mockWarningFn = jest.fn()
-
-  beforeEach(() => {
-    jest.spyOn(global.console, 'warn').mockImplementation(mockWarningFn)
-  })
-
-  afterEach(() => {
-    jest.clearAllMocks()
-  })
-
   behavesAsComponent({
     Component: ProgressBar,
     toRender: () => <ProgressBar aria-label="Upload test.png" aria-valuenow={10} progress={0} />,
@@ -123,18 +113,30 @@ describe('ProgressBar', () => {
     expect(getByRole('progressbar')).toHaveAttribute('aria-valuenow', '0')
   })
 
-  it('should warn users if aria-label is not provided', () => {
-    HTMLRender(<ProgressBar.Item progress={50} />)
-    expect(mockWarningFn).toHaveBeenCalled()
-  })
+  describe('console.warn', () => {
+    const mockWarningFn = jest.fn()
 
-  it('should not warn users if aria-label is not provided but aria-hidden is', () => {
-    HTMLRender(<ProgressBar.Item progress={50} aria-hidden={true} />)
-    expect(mockWarningFn).not.toHaveBeenCalled()
-  })
+    beforeEach(() => {
+      jest.spyOn(global.console, 'warn').mockImplementation(mockWarningFn)
+    })
+
+    afterEach(() => {
+      jest.clearAllMocks()
+    })
+
+    it('should warn users if aria-label is not provided', () => {
+      HTMLRender(<ProgressBar.Item progress={50} />)
+      expect(mockWarningFn).toHaveBeenCalled()
+    })
+
+    it('should not warn users if aria-label is not provided but aria-hidden is', () => {
+      HTMLRender(<ProgressBar.Item progress={50} aria-hidden={true} />)
+      expect(mockWarningFn).not.toHaveBeenCalled()
+    })
 
-  it('should not warn users if aria-label is  provided', () => {
-    HTMLRender(<ProgressBar.Item progress={50} aria-label="Uploading test.png" />)
-    expect(mockWarningFn).not.toHaveBeenCalled()
+    it('should not warn users if aria-label is  provided', () => {
+      HTMLRender(<ProgressBar.Item progress={50} aria-label="Uploading test.png" />)
+      expect(mockWarningFn).not.toHaveBeenCalled()
+    })
   })
 })