clean

primer · Jan 21, 2025 · 5517189 · 5517189
1 parent 6d3928a
commit 5517189
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 70 deletions.
diff --git a/e2e/components/all.test.ts b/e2e/components/all.test.ts
@@ -4,75 +4,6 @@ import {stories} from '../../packages/react/src/utils/testing'
 import {visit} from '../test-helpers/storybook'
 import {themes} from '../test-helpers/themes'
 
-// const stories: Array<{title: string; id: string; viewports?: Array<keyof typeof viewports>}> = [
-//   {
-//     title: 'Default',
-//     id: 'experimental-components-banner--default',
-//     viewports: ['primer.breakpoint.xs', 'primer.breakpoint.sm'],
-//   },
-//   {
-//     title: 'Critical',
-//     id: 'experimental-components-banner-features--critical',
-//   },
-//   {
-//     title: 'Dismiss',
-//     id: 'experimental-components-banner-features--dismiss',
-//   },
-//   {
-//     title: 'Dismiss With Actions',
-//     id: 'experimental-components-banner-features--dismiss-with-actions',
-//   },
-//   {
-//     title: 'Info',
-//     id: 'experimental-components-banner-features--info',
-//   },
-//   {
-//     title: 'Success',
-//     id: 'experimental-components-banner-features--success',
-//   },
-//   {
-//     title: 'Upsell',
-//     id: 'experimental-components-banner-features--upsell',
-//   },
-//   {
-//     title: 'Warning',
-//     id: 'experimental-components-banner-features--warning',
-//   },
-//   {
-//     title: 'WithActions',
-//     id: 'experimental-components-banner-features--with-actions',
-//     viewports: ['primer.breakpoint.xs', 'primer.breakpoint.sm'],
-//   },
-//   {
-//     title: 'WithHiddenTitle',
-//     id: 'experimental-components-banner-features--with-hidden-title',
-//   },
-//   {
-//     title: 'WithHiddenTitleAndActions',
-//     id: 'experimental-components-banner-features--with-hidden-title-and-actions',
-//     viewports: ['primer.breakpoint.xs', 'primer.breakpoint.sm'],
-//   },
-//   {
-//     title: 'DismissibleWithHiddenTitleAndActions',
-//     id: 'experimental-components-banner-features--dismissible-with-hidden-title-and-actions',
-//     viewports: ['primer.breakpoint.xs', 'primer.breakpoint.sm'],
-//   },
-//   {
-//     title: 'DismissibleWithHiddenTitleAndSecondaryAction',
-//     id: 'experimental-components-banner-features--dismissible-with-hidden-title-and-secondary-action',
-//     viewports: ['primer.breakpoint.xs', 'primer.breakpoint.sm'],
-//   },
-//   {
-//     title: 'InSidebar',
-//     id: 'experimental-components-banner-examples--in-sidebar',
-//   },
-//   {
-//     title: 'Multiline',
-//     id: 'experimental-components-banner-examples--multiline',
-//     viewports: ['primer.breakpoint.xs', 'primer.breakpoint.sm'],
-//   },
-// ]
-
 test.describe('axe @aat', () => {
   for (const {story, relativeFilepath, type} of stories) {
     for (const storyName of Object.keys(story)) {

diff --git a/packages/react/src/Button/ButtonBase.tsx b/packages/react/src/Button/ButtonBase.tsx
@@ -72,7 +72,8 @@ const ButtonBase = forwardRef(
         if (
           innerRef.current &&
           !(innerRef.current instanceof HTMLButtonElement) &&
-          !((innerRef.current as unknown) instanceof HTMLAnchorElement)
+          !((innerRef.current as unknown) instanceof HTMLAnchorElement) &&
+          !((innerRef.current as HTMLElement).tagName === 'SUMMARY')
         ) {
           // eslint-disable-next-line no-console
           console.warn('This component should be an instanceof a semantic button or anchor')