Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map border.tertiary to border.default #242

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Map border.tertiary to border.default #242

merged 2 commits into from
Sep 22, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Sep 22, 2021

This maps the deprecated border.tertiary to border.default.

Reasoning

This came up in primer/css#1615. The history seems to be:

  • In pre primitives border-gray-dark was the "strongest", most contrasting border color
  • In primitives v1 it got renamed to color-border-tertiary which probably suggests it's the "weakest", but the color was still stronger than the default border.
  • So because in primitives v2 the default border is the strongest, I think it would make sense to use this mapping:

.border-gray-dark -> .color-border-tertiary -> .color-border-default

Here a screenshot of color-border-tertiary from v1:

image

Keeping the current color-neutral-subtle would make the border barely visible:

image

We might also want to change all the border-tertiary -> neutral-muted migrations in https://github.com/github/github/pull/192360 to border-default. E.g. the border for this "Load more" button would be pretty hard to see:

Screen Shot 2021-09-21 at 17 34 49

/cc @ashygee

@simurai simurai requested a review from a team as a code owner September 22, 2021 06:24
@simurai simurai requested review from jonrohan and removed request for a team September 22, 2021 06:24
@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2021

🦋 Changeset detected

Latest commit: ba564a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/BW5cf4ZKKzikueQ1kTBWvmUXUyc5
✅ Preview: https://primitives-git-border-tertiary-primer.vercel.app

@jonrohan jonrohan merged commit c57b590 into main Sep 22, 2021
@jonrohan jonrohan deleted the border-tertiary branch September 22, 2021 20:41
@primer-css primer-css mentioned this pull request Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants