Map border.tertiary
to border.default
#242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This maps the deprecated
border.tertiary
toborder.default
.Reasoning
This came up in primer/css#1615. The history seems to be:
border-gray-dark
was the "strongest", most contrasting border colorcolor-border-tertiary
which probably suggests it's the "weakest", but the color was still stronger than the default border..border-gray-dark
->.color-border-tertiary
->.color-border-default
Here a screenshot of
color-border-tertiary
from v1:Keeping the current
color-neutral-subtle
would make the border barely visible:We might also want to change all the
border-tertiary
->neutral-muted
migrations in https://github.com/github/github/pull/192360 toborder-default
. E.g. the border for this "Load more" button would be pretty hard to see:/cc @ashygee