Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-deprecated-colors] Handle sx prop edge cases #6

Merged
merged 3 commits into from
Sep 20, 2021
Merged

[no-deprecated-colors] Handle sx prop edge cases #6

merged 3 commits into from
Sep 20, 2021

Conversation

colebemis
Copy link
Contributor

The no-deprecated-colors rule can now find deprecated colors in the following cases:

  • Nested sx properties:

    <Box sx={{'&:hover': {bg: 'bg.primary'}}}>

  • Functions in sx prop:

    <Box sx={{boxShadow: theme => `0 1px 2px ${theme.colors.text.primary}`}}>

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: dd14594

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colebemis colebemis requested a review from jonrohan September 20, 2021 17:12
@colebemis colebemis merged commit 56557b4 into main Sep 20, 2021
@primer-css primer-css mentioned this pull request Sep 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colebemis @jonrohan