Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More buttons #959

Merged
merged 10 commits into from
Oct 25, 2019
Merged

More buttons #959

merged 10 commits into from
Oct 25, 2019

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Oct 24, 2019 •
edited
Loading

This PR adds a few more buttons that are used on dotcom but are undocumented.

✨ Preview ✨

image

TODO

  • Add button styles from dotcom
  • Improve documentation
  • Reorg styles
  • Move .details-reset to /utilities/details.scss 6013909

TODO on dotcom

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Oct 24, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/plfdal08s
🌍 Preview: https://primer-css-git-buttons.primer.now.sh

@simurai simurai marked this pull request as ready for review October 24, 2019 11:24
@shawnbot shawnbot changed the base branch from master to release-13.2.0 October 24, 2019 20:24
shawnbot
shawnbot approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's include this in #954.

@simurai simurai merged commit 3100ca3 into release-13.2.0 Oct 25, 2019
@simurai simurai deleted the buttons branch October 25, 2019 04:47
@shawnbot shawnbot mentioned this pull request Oct 25, 2019
Merged
15 tasks
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Open
@github-actions github-actions bot mentioned this pull request Dec 23, 2022
Open
@github-actions github-actions bot mentioned this pull request Jan 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnbot shawnbot shawnbot approved these changes

Assignees
No one assigned
Labels
minor release Tag: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simurai @shawnbot @khemarato