-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Diffstat component #950
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/azbv71e7c |
@simurai if we name the variable for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion is to create two new variables for these colors: $bg-diffstat-added: darken($green-400, 5%)
and $bg-diffstat-deleted: $red-600
. Currently, if we were to run this through our new stylelint rules we'd have primer/colors
violations for both values, since neither is a $bg-
variable.
Co-Authored-By: Shawn Allen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simurai FYI I moved the new $bg-diffstat-*
variable declarations to colors.scss
and flagged them with !default
per existing conventions. I think this is good to go!
Was wondering if we should organize variables per component or property. 👍 Good for now. |
This adds the
.diffstat
component to Primer CSS.✨ Docs Preview
TODO
Maybe tweak colors to not usedarken()
TODO on dotcom
diffstat.scss
/cc @primer/ds-core