Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce .flex-column-reverse utility #927

Merged
merged 3 commits into from
Oct 10, 2019
Merged

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Oct 2, 2019

This adds the .flex-column-reverse utilities to complete the rest of the directional classes.

TODO

  • Add utility
  • Add documentation

Size changes

┌─────────────────────┬───────────┬─────┬───────────┬────────┬──────────┬─────────┬──────────────────────────────┐
│ name                │ selectors │   ± │ gzip size │      ± │ raw size │       ± │ path                         │
├─────────────────────┼───────────┼─────┼───────────┼────────┼──────────┼─────────┼──────────────────────────────┤
│ primer              │      3290 │ + 5 │    26.3 K │ + 24 B │ 165.73 K │ + 322 B │ dist/primer.css              │
│ core                │      2206 │ + 5 │   17.52 K │ + 23 B │  111.2 K │ + 322 B │ dist/core.css                │
│ utilities           │      1357 │ + 5 │    8.61 K │ + 24 B │  65.55 K │ + 322 B │ dist/utilities.css           │

Closes #915

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Oct 2, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-flex-column-reverse.primer.now.sh

@shawnbot shawnbot changed the base branch from master to release-14.0.0 October 3, 2019 21:38
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! I've changed the base to #925 since we'll probably (hopefully!) get around to that before another minor release.

This was referenced Oct 3, 2019
@simurai simurai changed the base branch from release-14.0.0 to release-13.1.0 October 8, 2019 00:19
@simurai simurai merged commit b1a15e6 into release-13.1.0 Oct 10, 2019
@simurai simurai deleted the flex-column-reverse branch October 10, 2019 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants