Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Segoe UI Symbol" from font stack #906

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Sep 23, 2019

This removes Segoe UI Symbol from the $body-font stack.

Reasoning

See issue https://github.com/github/design-systems/issues/710 and more specifically this comment https://github.com/github/design-systems/issues/710#issuecomment-533818820.

In short Segoe UI Symbol is used as a fallback for native emoji support. Removing Segoe UI Symbol allows users to have other fonts that use the same "private" unicode characters. For example to display certain chinese symbols.

Concerns

I think it's only an issue for people still on Windows 7 and only affects non-markdown areas on dotcom.. like the title of an issue.

/cc @muan @primer/ds-core

@vercel
Copy link

vercel bot commented Sep 23, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-segoe-ui-symbol.primer.now.sh

@simurai
Copy link
Contributor Author

simurai commented Sep 23, 2019

I tagged this as patch release + Tag: Bug Fix although at the same time it could be a "breaking change" and therefore part of a major release? As I understood it, it's pretty important to get this released as soon as possible. So maybe just a patch release is fine?

@simurai simurai mentioned this pull request Sep 23, 2019
6 tasks
@simurai
Copy link
Contributor Author

simurai commented Sep 23, 2019

Ok, I'm gonna merge this already into #905 and we can keep it as the only change. So that we don't have to test anything else.

@simurai simurai merged commit 4889e7a into release-13.0.1 Sep 23, 2019
@simurai simurai deleted the segoe-ui-symbol branch September 23, 2019 09:08
This was referenced Sep 24, 2019
sindresorhus added a commit to sindresorhus/modern-normalize that referenced this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant