Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Doctocat + update LivePreviewWrapper #895

Merged
merged 2 commits into from
Sep 12, 2019

Conversation

emplums
Copy link
Contributor

@emplums emplums commented Sep 12, 2019

This PR updates Doctocat to 0.15.0 - which requires a change to our shadowed live-preview-wrapper.js. Just needed to wrap those components in an iframe as it's been moved out of the theme component :)

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Sep 12, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-shadow-live-preview.primer.now.sh

@shawnbot shawnbot changed the base branch from master to release-13.0.0 September 12, 2019 20:16
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's add this to #887 since it's going out soon.

@shawnbot shawnbot merged commit e4ce9e9 into release-13.0.0 Sep 12, 2019
@shawnbot shawnbot deleted the shadow-live-preview branch September 12, 2019 20:17
@shawnbot shawnbot mentioned this pull request Sep 12, 2019
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants