Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecations test script; run on release branches #889

Merged
merged 14 commits into from
Sep 10, 2019

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Sep 10, 2019

This adds a deprecations test script (and Actions workflow step, which runs only on release-* branches) that ensures:

  1. We have removed all selectors from the generated CSS that are listed in the deprecations data for the current version (in which case, we should remove them from the deprecations data); and
  2. We have not removed any selectors that aren't listed in the deprecations data (in which case, we should add them back).

Currently this test is running and failing on this branch because it begins with release- (whoops), and will fail #887 until we merge #736 and #662.

Running script/test-deprecations.js --help explains how it works:


script/test-deprecations.js [options]

  --version <version>    The published version of @primer/css from which to
                         fetch CSS selector stats; default: "latest".
  --bundle <bundle>      The CSS bundle to compare; default: "primer".

Fetches the CSS selectors for the published package and checks that:

1. All selectors listed in deprecations.js for the current local version (in
   package.json) have been deleted.
2. All selectors deleted in the current local version have been listed in
   deprecations.js.

If either check fails, the process exits with an error status (1).

TODO

@vercel
Copy link

vercel bot commented Sep 10, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-release-workflow.primer.now.sh

@vercel vercel bot temporarily deployed to staging September 10, 2019 00:05 Inactive
@vercel vercel bot temporarily deployed to staging September 10, 2019 05:29 Inactive
@vercel vercel bot temporarily deployed to staging September 10, 2019 05:33 Inactive
@vercel vercel bot temporarily deployed to staging September 10, 2019 05:45 Inactive
@shawnbot shawnbot changed the base branch from release-13.0.0 to delete-pending-classes September 10, 2019 18:24
@shawnbot shawnbot changed the base branch from delete-pending-classes to tidy-scripts-deps September 10, 2019 18:31
@shawnbot shawnbot mentioned this pull request Sep 10, 2019
15 tasks
@shawnbot shawnbot marked this pull request as ready for review September 10, 2019 18:55
@shawnbot shawnbot changed the base branch from tidy-scripts-deps to release-13.0.0 September 10, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant