-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecations test script; run on release branches #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-css-git-release-workflow.primer.now.sh |
shawnbot
force-pushed
the
release-workflow
branch
from
September 10, 2019 05:58
3bcf105
to
bdf675b
Compare
shawnbot
changed the base branch from
release-13.0.0
to
delete-pending-classes
September 10, 2019 18:24
shawnbot
changed the base branch from
delete-pending-classes
to
tidy-scripts-deps
September 10, 2019 18:31
BREAKING CHANGE: .text-pending is officially deprecated BREAKING CHANGE: .bg-pending is officially deprecated
shawnbot
force-pushed
the
release-workflow
branch
from
September 10, 2019 20:06
0a4eb49
to
6869e77
Compare
shawnbot
changed the title
Add deprecations test workflow
Add deprecations test script; run on release branches
Sep 10, 2019
This was referenced Sep 10, 2019
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a deprecations test script (and Actions workflow step, which runs only on
release-*
branches) that ensures:Currently this test is running and failing on this branch because it begins with
release-
(whoops), and will fail #887 until we merge #736 and #662.Running
script/test-deprecations.js --help
explains how it works:TODO