Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to [email protected] #747

Merged
merged 3 commits into from
Apr 8, 2019
Merged

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Apr 5, 2019

The latest release of cssstats fixes a bug with the selector stats that was mistakenly including selector-like @keyframes declarations. Running script/selector-diff-report generates this diff:

788,789d787
< from
< to
852,853d849
< 0%
< 100%
856,857d851
< 0%
< 100%
859,860d852
< 0%
< 100%
862,863d853
< 0%
< 100%
865d854
< to
867d855
< to
869,870d856
< 0%
< 100%
872,874d857
< 0%
< 10%
< 100%
876,878d858
< 0%
< 50%
< 100%

This is a prerequisite of primer/stylelint-config#25, because that will throw errors for any keyframe animation with matching breakpoints.

@shawnbot
Copy link
Contributor Author

shawnbot commented Apr 5, 2019

Heads up: the diff for this is off because #744 was merged directly to master, and that included some funky new additions to our package.json in non-alphabetical key order. 🤔

@@ -117,13 +122,6 @@
"unist-util-select": "^2.0.0",
"unist-util-stringify-position": "^2.0.0",
"unist-util-visit": "^1.4.0",
"webpack": "4.20.2",
"@primer/components": "12.0.1",
"@primer/next-pages": "0.0.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emplums I uninstalled @primer/next-pages in this PR because it comes with @primer/blueprints.

"webpack": "4.20.2",
"@primer/components": "12.0.1",
"@primer/next-pages": "0.0.3",
"fs": "0.0.1-security",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emplums I also uninstalled fs because it's not really a package 😄

@simurai simurai mentioned this pull request Apr 8, 2019
8 tasks
@shawnbot shawnbot merged commit 85d11f1 into release-12.2.2 Apr 8, 2019
@shawnbot shawnbot deleted the upgrade-cssstats branch April 8, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant