Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeView single item nesting #1937

Merged
merged 3 commits into from
Feb 11, 2022
Merged

TreeView single item nesting #1937

merged 3 commits into from
Feb 11, 2022

Conversation

langermank
Copy link
Contributor

If a single item exists in a Tree View next to a collapsible group, align item with nearby group's icon

before after
tree-view before fix tree-view after fix

An attempt was made 😅 to handle this purely with CSS, but we can't handle the top level case (can't go up the tree in CSS, literally). This creates a new class ActionList-item--singleton to be conditionally added to ActionList-item when its needed. I confirmed with @talum that we have that data in the view component.

@langermank langermank requested a review from a team as a code owner February 11, 2022 18:49
@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2022

🦋 Changeset detected

Latest commit: db44090

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank merged commit 67f0800 into main Feb 11, 2022
@langermank langermank deleted the tree-view-followup branch February 11, 2022 19:39
@primer-css primer-css mentioned this pull request Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants