Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover and active states to btn-invisible #1808

Merged
merged 3 commits into from
Dec 3, 2021

Conversation

manuelpuyol
Copy link
Contributor

Related to https://github.com/github/primer/issues/253 and https://github.com/github/primer/issues/263

Adds hover and active states to btn-invisible, as proposed by @vdepizzol.

Screen.Recording.2021-12-02.at.4.14.24.PM.mov

/cc @primer/css-reviewers

@manuelpuyol manuelpuyol requested a review from a team as a code owner December 2, 2021 22:15
@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2021

🦋 Changeset detected

Latest commit: d0ab8ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank
Copy link
Contributor

This looks good! But I'm curious why it didn't deploy to docs/storybook 🤔

@simurai
Copy link
Contributor

simurai commented Dec 3, 2021

@langermank But I'm curious why it didn't deploy to docs/storybook

Storybook deploys should work again. 😌

@manuelpuyol manuelpuyol merged commit ee27583 into main Dec 3, 2021
@manuelpuyol manuelpuyol deleted the invisible-button-hover branch December 3, 2021 15:27
This was referenced Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants