Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating and autofixing stylelint #1765

Merged
merged 14 commits into from
Dec 8, 2021
Merged

Conversation

jonrohan
Copy link
Member

This is an example PR for this stylelint-config update primer/stylelint-config#168

I'm installing the canary version and running yarn stylelint --fix to show what it would look like here.

@jonrohan jonrohan requested a review from a team as a code owner November 24, 2021 00:30
@changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2021

⚠️ No Changeset found

Latest commit: cd5e5e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -1,5 +1,4 @@
@import '../support/index.scss';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda liked that the import that doesn't output any styles is somewhat visually separated. But we can always add a comment to separate it. So the stylelint rule should still be fine to keep.

@@ -172,7 +172,7 @@
visibility: hidden;
opacity: 0;
transition:
visibility 0 linear $actionList-item-checkmark-transition-timing,
visibility 0 linear $actionList-item-checkmark-transition-timing,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was driving me crazy!

jonrohan and others added 6 commits December 8, 2021 09:29
* Use reusable release_canary workflow

* Install with yarn

Co-authored-by: Jon Rohan <[email protected]>
* Use counter-border for LHC

* Create orange-ties-sin.md

* Remove fallback
* add pseudo selectors

* adjustments

* add stories, cleanup

* update mixin

* fix mixin

* lint

* add back overflow styles

* adjust focus for better overflow state, scrollsnap

* post test adjustments, move hacks to primer css

* Stylelint auto-fixes

* hover state desktop only

* document data-content hack

* Create nice-days-jog.md

Co-authored-by: Actions Auto Build <[email protected]>
Co-authored-by: simurai <[email protected]>
@jonrohan jonrohan enabled auto-merge (squash) December 8, 2021 17:38
@jonrohan jonrohan merged commit e8d5402 into main Dec 8, 2021
@jonrohan jonrohan deleted the primer-stylelint-config-12.2.0 branch December 8, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants