Replace auto and fade variables #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1d48bb3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Since the v2 variables are not available yet
This should not be needed anymore.
simurai
commented
Jun 7, 2021
Spoke with @simurai but I think we can use v2 here with the fallback. Will fix the stylelint in this PR. |
This reverts commit cc620b9.
jonrohan
approved these changes
Jun 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces/aliases all
autoandfadevariables in preparation for V2.Initially I tried to use the new V2 variables with a fallback, like
var(--color-v2, var(--color-v1)). But unlike on dotcom where we can load a separate CSS bundle, in Primer CSS I don't think we have that mechanism. So this PR tries to replace thefade+autovariables with existing V1 variables.