Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout grid ordering with sidebar placement #1432

Merged
merged 4 commits into from
Jun 1, 2021

Conversation

manuelpuyol
Copy link
Contributor

When the sidebar was placed at the end by using either Layout--sidebarPosition-end or Layout--sidebarPosition-flowRow-end, the content wasn't being placed correctly if a divider was present.

Before After
image image
image image

@changeset-bot
Copy link

changeset-bot bot commented May 27, 2021

🦋 Changeset detected

Latest commit: 338a891

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@manuelpuyol
Copy link
Contributor Author

@jonrohan @simurai could one of you merge this? I don't have merge permissions 😬

@jonrohan jonrohan merged commit 53b70fc into main Jun 1, 2021
@jonrohan jonrohan deleted the layout-grid-ordering-with-sidebar-placement branch June 1, 2021 15:58
@primer-css primer-css mentioned this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants