Marketing: Enable body content utilities to have their font-weight overwritten #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0fea11a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simurai
approved these changes
May 11, 2021
There was a problem hiding this comment.
As a general rule, all utilities use !important and should only style a single CSS property. So these marketing typography "utilities" feel more like being "components" that can be overridden with the text-bold utility.
Maybe in the future we could move them into the "Components" category? Call it "Marketing typography" or similar.
Merged
|
@simurai I think that makes sense 🙏 I'll open a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
!importantfrom thefont-weightdeclarations for.f0-mktg-.f6-mktg, so that they can be overridden with e.g..text-bold.Since the marketing typography is included after the primer core utility classes, adding
!importantwhen setting a property in the marketing bundle will make it impossible to override that value with a primer core utility class. In some instances this is acceptable, or possibly even a feature (to enforce consistency), but it's at least clear that for body content we need to be able to change thefont-weight.