-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typography-base: process 'type' attribute of HTML <ol> tag #1357
Conversation
Some markup languages like AsciiDoc, allow defining the 'type' attribute of HTML <ol> tag. For instance, the following AsciiDoc code: [loweralpha] . item1 . item2 Produces in GitHub the HTML code: <ol type="a"> <li>item1</li> <li>item2</li> </ol> The current SCSS doesn't cover this 'type' attribute, so the regular default symbol (decimal) applies, instead of the one intended by the author. Signed-off-by: Hector Palacios <[email protected]>
🦋 Changeset detectedLatest commit: 42ebe55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Interesting! I didn't realize it could do that, could you provide an example to a rendered link? I might want to namespace this so we're not directly effecting all |
Hi @jonrohan
The second part has some specifiers: loweralpha for level 2, lowerroman for level 3, decimal for level 4. You can inspect the code to see how such lists render.
I was expecting "decimal" or "arabic" to also render as In any case, without a specific style for the |
Thanks so much @hpalacio! Going to include it in the next release |
Some markup languages like AsciiDoc, allow defining the 'type'
attribute of HTML
<ol>
tag.For instance, the following AsciiDoc code:
Produces in GitHub the HTML code:
The current SCSS doesn't cover this 'type' attribute, so the regular
default symbol (decimal) applies, instead of the one intended by the
author.
Signed-off-by: Hector Palacios [email protected]