Increase border contrast for Label--yellow

[simurai]

This makes the border of the Label--yellow a bit darker:

Before	After
yellow-600	yellow-800

Reasoning

We got feedback that the yellow labels are harder to see: https://github.com/github/github/issues/149846 (internal)

Alternatives

We could also use yellow-700 for the border.

It would fail the AA color contrast ratio for graphical objects. But at the same time it would be more recognizable as "yellow".

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-css/5xg7dq35j
✅ Preview: https://primer-css-git-label-yellow.primer.vercel.app

[colinkeany]

I would suggest, for the sake of passing AA, that we use -800. I think it's more important that the word "Pending" is passing. The board color is mostly a visual treatment that supports the status.

[simurai]

@colinkeany I would suggest, for the sake of passing AA, that we use -800. I think it's more important that the word "Pending" is passing.

To clarify.. this PR only changes the border color. The text color is already using the darkest yellow-900 and that passes AA. ✅

[colinkeany]

@colinkeany I would suggest, for the sake of passing AA, that we use -800. I think it's more important that the word "Pending" is passing.

To clarify.. this PR only changes the border color. The text color is already using the darkest yellow-900 and that passes AA. ✅

Yes sorry if that wasn't clear! I was speaking about the border color.

[simurai]

Sorry.. ok, I see. Your point is that the border is just as important as the text and should pass AA too. 👍

@auareyou any objections? Here a border color of yellow-800 compared to the other labels:

[auareyou]

Sorry.. ok, I see. Your point is that the border is just as important as the text and should pass AA too. 👍

@auareyou any objections? Here a border color of yellow-800 compared to the other labels:

I think that for the sake of uniformity yellow-800 makes more sense and it seems more consistent with the rest.

[simurai]

yellow-800 makes more sense

👍 Ok, the border is now yellow-800.

[auareyou]

Looks good to me! 🎨