Skip to content

Commit

Permalink
Make TimelineItem-badge--success ready for V2 (#1475)
Browse files Browse the repository at this point in the history
* Use btn-primary-text for TimelineItem-badge--success

* Use emphasis color

* Create silent-cycles-camp.md
  • Loading branch information
simurai authored Jun 28, 2021
1 parent 369c5cc commit 105296c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/silent-cycles-camp.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": patch
---

Make `TimelineItem-badge--success` ready for Color Modes V2
4 changes: 2 additions & 2 deletions src/timeline/timeline-item.scss
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
flex-shrink: 0;

&--success {
color: var(--color-text-white);
background-color: var(--color-btn-primary-bg);
color: var(--color-fg-on-emphasis, var(--color-btn-primary-text)); // TODO remove V1 fallback
background-color: var(--color-success-emphasis, var(--color-btn-primary-bg)); // TODO remove V1 fallback
border: $border-width $border-style var(--color-timeline-badge-success-border);
}
}
Expand Down

0 comments on commit 105296c

Please sign in to comment.