Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "sortField" prop type in Column, DataTable, TableHeader, DataView and TreeTable (PrimeVue 2) #743

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/column/Column.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import Vue from 'vue';
declare class Column extends Vue {
columnKey?: any;
field?: string;
sortField?: string | ((item: any) => any);;
sortField?: string | ((item: any) => any);
filterField?: string;
sortable?: boolean;
header?: any;
Expand All @@ -30,4 +30,4 @@ declare class Column extends Vue {
frozen?: boolean;
}

export default Column;
export default Column;
4 changes: 2 additions & 2 deletions src/components/column/Column.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default {
default: null
},
sortField: {
type: String,
type: [String, Function],
default: null
},
filterField: {
Expand Down Expand Up @@ -115,4 +115,4 @@ export default {
return null;
}
}
</script>
</script>
2 changes: 1 addition & 1 deletion src/components/datatable/DataTable.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,4 @@ declare class DataTable extends Vue {
}
}

export default DataTable;
export default DataTable;
2 changes: 1 addition & 1 deletion src/components/dataview/DataView.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ declare class DataView extends Vue {
}
}

export default DataView;
export default DataView;
2 changes: 1 addition & 1 deletion src/components/dataview/DataView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -218,4 +218,4 @@ export default {
'DVPaginator': Paginator
}
}
</script>
</script>
2 changes: 1 addition & 1 deletion src/components/treetable/TreeTable.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@ declare class TreeTable extends Vue {
}
}

export default TreeTable;
export default TreeTable;