Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change controlled condition in BaseEditableHolder #6816

Closed
wants to merge 2 commits into from

Conversation

KumJungMin
Copy link
Contributor

@KumJungMin KumJungMin commented Nov 19, 2024

Defect Fixes

How to Resolve...?

  • If the controlled condition changed, the datePicker input can be controlled via the keyboard.
2024-11-19.11.19.23.mov

  • However, I don't think this is a perfect solution. Understanding the purpose of modifying controlled in this PR might help in finding a smoother fix. @mertsincan
  • I would appreciate any comments regarding this matter! :)

Note: In datePicker, inProps does not include modelValue.

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 3:21pm
primevue-v3 ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 3:21pm

@KumJungMin KumJungMin changed the title fix: replace || operator with nullish coalescing operator ?? fix: change controlled condition in BaseEditableHolder Nov 19, 2024
@timothymarois
Copy link

+1 vote for this change to be merged. It is very necessary from a UX perspective.

@mertsincan
Copy link
Member

Thanks a lot for your contribution! Fixed in 0415d0b

Best Regards,

@mertsincan mertsincan closed this Dec 11, 2024
@KumJungMin KumJungMin deleted the fix/issue-6739 branch December 13, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatePicker: manual input not working
3 participants