Update StepPanel.vue with v-show rather than v-if for horizontal steps. #6054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fix for StepPanel.vue so that v-show is used rather than v-if. v-show is desired as the Stepper should not be re-rendering components.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
using v-show affects performance. v-show causes to load unused step components. generally users do not use all steps every time. |
|
#5495 addresses this issue as well and it was updated to v-show in v3. Isn't the point of the stepper to go through all the steps, especially if you are using linear? And especially for forms, information in other steps need to persist so it can all be sent to the database. v3 Stepper loaded all components, so this is a new unexpected behaviour in v4. Also, then why does vertical use v-show? That seems inconsistent to me. Maybe if someone wants to do build this feature out, there could be an option to determine whether to load the step or not. |
tugcekucukoglu
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for StepPanel.vue so that v-show is used rather than v-if. v-show is desired as the Stepper should not be re-rendering components.
###Defect Fixes
Fixes #6052