Fix positioning of overlay arrows #5975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
tugcekucukoglu
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###Defect Fixes
This fixes #5915
A few things:
ConfirmPopupwas definingoverlay.arrow.leftbut there were no references tooverlaydesign tokenPopoverdefinespopover.arrow.left, but only usespopover.arrow.offsetoverlay.arrow.lefttoconfirmpopup.arrow.leftto follow convention (there is an existingconfirmpopup.arrow.offset)arrow.leftin the arrow CSS, as I believe the separate tokenarrow.offsetwas meant for a fixed offset based on arrow sizeResult:
arrow.leftvalues forconfirmpopupandpopoverare actually used in the positioning of the arrow to make it dynamic based on screen location.arrow.offsettoken is still used for arrow theming.