Fix documented default for emptyMessage on several components #5850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the documented default value for the "emptyMessage" property for the Dropdown, Listbox, MultiSelect and TreeSelect components. They were all incorrectly documented as having a default value of "No results found". I changed each one to "No available options".
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
There is no need to change apidoc/index.json. Components' .d.ts files must be changed. For example: https://github.com/primefaces/primevue/blob/master/components/lib/dropdown/Dropdown.d.ts#L487 Actions will be updated according to .d.ts changes. |
tugcekucukoglu
added
the
Resolution: Needs Revision
This reverts commit ee79538.
Fixed the documented default value for the "emptyMessage" property for the Dropdown, Listbox, MultiSelect and TreeSelect components in the components' type definition files. I have changed the values from "No results found" to "No available options".
|
@tugcekucukoglu Sorry for diving straight in and getting it wrong, and thanks for pointing me to the right place. Hopefully my amendments are the correct resolution. |
tugcekucukoglu
approved these changes
Jun 10, 2024
tugcekucukoglu
removed
the
Resolution: Needs Revision
tugcekucukoglu
added
the
Type: Bug
|
The changes you made are exactly the solution we are looking for. We gladly accept the PR. Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the documented default value for the "emptyMessage" property for the Dropdown, Listbox, MultiSelect and TreeSelect components. They were all incorrectly documented as having a default value of "No results found". I changed each one to "No available options".