Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Make TreeNode.key required #5835

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

jacobtylerwalls
Copy link
Contributor

This property is documented as mandatory.

Suggesting to remove ? so that in my own code I no longer have to add not-null assertions like .node.key!.

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2024 2:33pm
primevue-v4 ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2024 2:33pm

@tugcekucukoglu tugcekucukoglu merged commit 1f25f45 into primefaces:master Jun 7, 2024
3 of 4 checks passed
@tugcekucukoglu tugcekucukoglu added this to the 3.53.0 milestone Jun 7, 2024
@jacobtylerwalls jacobtylerwalls deleted the require-key branch June 7, 2024 14:38
@jacobtylerwalls jacobtylerwalls restored the require-key branch July 4, 2024 14:08
@jacobtylerwalls jacobtylerwalls deleted the require-key branch July 4, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants