Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #4120 - DataTable: Selection and Row/Cell editing : Cannot input space character #4333

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

NikoGJ
Copy link
Contributor

@NikoGJ NikoGJ commented Aug 27, 2023

Fixes #4120

Uses the self modifier on keydown event to catch events emitted on the tag only. This allows keydown events to be handled lower in the DOM tree and still allows row selection with keyboard.

Note that input by inputing a space or enter character in an Input field, it does not select the row where the Input belongs to.

@vercel
Copy link

vercel bot commented Aug 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2023 9:38pm

@mertsincan mertsincan merged commit 88ac7e2 into primefaces:master Sep 5, 2023
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataTable: Selection and Row/Cell editing : Cannot input space character
2 participants